WIP: separate evergreen vs legacy support

angular / zone.js

Implements Zones for JavaScript

https://github.com/angular/angular/tree/master/packages/zone.js/

MIT License

3.25k stars 407 forks source link

WIP: separate evergreen vs legacy support #1186

Closed JiaLiPassion closed 5 years ago

JiaLiPassion commented 5 years ago

in this PR we have two zone dist bundles.

The bundles.
1. zone.js this is still the full package include support for evergreen and legacy (IE/Old Firefox/Safari)
2. zone-evergreen.js only includes the support for evergreen browsers.
3. zone-legacy.js will only contain the patch of legacy browser.
What is in the legacy patch.
1. registerElement patch (evergreen will only patch customElements).
2. Events patch (addEventListener...) if EventTarget is not available.
3. onProperty patch such as (onclick) , when propertyDescriptor is not patchable.
Others
1. separate fetch patch into a standalone bundle zone-patch-fetch.
2. separate canvas patch into a standalone bundle zone-patch-canvas.

aitboudad commented 5 years ago

I think we may need 3:

zone.js the full package
zone-evergreen.js
zone-legacy.js

JiaLiPassion commented 5 years ago

@aitboudad, sure, I will make it that way.

JiaLiPassion commented 5 years ago

@mhevery, @IgorMinar please review, thanks!

Compare the size between zone-evergreen.min.js and zone.min,js, zone-evergreen.min.js will be 4k less.

All tests passed for both zone.js and zone-evergreen.js, but the travis ci is red because saucelabs not stable.

IgorMinar commented 5 years ago

maybe let's not boil the ocean here... could we split these things into separate PRs?

JiaLiPassion commented 5 years ago

@IgorMinar, got it, I will ask @alexeagle 's help to make the es6 bundles and Bazel in other PRs, I just updated the rollup-main and README, please review, thanks!

JiaLiPassion commented 5 years ago

@IgorMinar, I have updated the README, please review, thanks!

IgorMinar commented 5 years ago

looks great. is the CI failure just a flake? I've restarted the travis job so let's see if it goes green.

JiaLiPassion commented 5 years ago

@IgorMinar , thanks, CI failure is a saucelabs flake, in their website, they said will support Firefox 65, but I can't launch it in our Travis CI. I have tried 60~65, none working in most cases, I only see it success one time....

IgorMinar commented 5 years ago

@JiaLiPassion should we remove that browser from the CI then? it doesn't help to test against that old browser when the test always fails.

IgorMinar commented 5 years ago

thank you @JiaLiPassion

JiaLiPassion commented 5 years ago

@IgorMinar , Got it, It seems you already merged it, I will remove Firefox 65 in the other PR, Thanks!