search

angular / zone.js

Implements Zones for JavaScript
https://github.com/angular/angular/tree/master/packages/zone.js/
MIT License
3.25k stars 408 forks source link

fix(zone-patch-rxjs): make retryWhen work #1248

Closed NicBright closed 5 years ago

NicBright commented 5 years ago

This PR is intended to fix #1194 and #1227

I've not included a test yet because I want to get feedback first whether this change looks good or not. @JiaLiPassion what do you think?

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

NicBright commented 5 years ago

@JiaLiPassion: the tests failed because of a timeout ... could you maybe restart the test run? Or shall I push another dummy commit?

JiaLiPassion commented 5 years ago

@NicBright , thanks for the PR, I will restart CI, and could you explain why unsubscribe will be null with a simple reproduce repo? And if possible, please add a test case in zone.js also, thanks!.

JiaLiPassion commented 5 years ago

@NicBright , could you explain why the unsubscribe will be null and also create a new PR in angular repo, because now the zone.js repo will be archived.

alexeagle commented 5 years ago

sorry for the churn @NicBright - we hope you'll follow us to the Angular monorepo and re-submit the PR.