refactor!: remove SlowComponentLoader and ReflectiveInjector.

angulardart-community / angular

Fast and productive web framework provided by Dart.

https://pub.dev/packages/ngdart

MIT License

114 stars 15 forks source link

refactor!: remove SlowComponentLoader and ReflectiveInjector. #26

Closed ykmnkmi closed 2 years ago

ykmnkmi commented 2 years ago

BREAKING CHANGE: remove SlowComponentLoader, ReflectiveInjector classes with dependent runAppLegacy, runAppLegacyAsync and bootstrapStatic functions.

GZGavinZhao commented 2 years ago

I'm trying to enforce conventional commit now, so if you want to squash & merge this PR as one big commit, please rename the PR title (which will become the commit title) when you submit this as ready for review. Otherwise, when submitting, please rebase/edit/squash/force push or whatever you like to ensure individual commits follow conventional commit guidelines.

GZGavinZhao commented 2 years ago

Just one small thing, in the function I commented on, did you mean to type missingServiceFactory instead of missingServicFactory?

ykmnkmi commented 2 years ago

Yes.