search

angulardart-community / angular_components

High-quality Material Design components for AngularDart.
https://gallery.angulardart.xyz
20 stars 15 forks source link

Run dart migrate #38

Closed lejard-h closed 2 years ago

lejard-h commented 2 years ago

Run dart migrate everywhere without accepting changes. So we have // @dart=2.9 header on every file and all pubspec.yaml opt in to null safety

Also use observable package from github rep (see #34)

Fix #41

lejard-h commented 2 years ago

@GZGavinZhao Can we have a null-safety branch to merge this and keep master branch without null safety.

Or do you want to keep dev branch (I am not sure if it's building right now)

GZGavinZhao commented 2 years ago

Yes, null-safety sounds good to me. I think for now it's better to leave dev clean as I'm not sure what @dukefirehawk is up to.

GZGavinZhao commented 2 years ago

@lejard-h Done. You can create a PR to that branch now. I will fix the workflow error on master and merge the change to null-safety later.