search

angulardart-community / angular_components

High-quality Material Design components for AngularDart.
https://gallery.angulardart.xyz
20 stars 15 forks source link

remove deprecated #47

Closed jodinathan closed 2 years ago

jodinathan commented 2 years ago

Fixed all files.
Exception from the material_input_multiline.dart at: 

// TODO(google): remove after the bug is fixed.
          ..detectChanges();

As I don't know what bug it is talking about.

jodinathan commented 2 years ago

fixes https://github.com/angulardart-community/angular_components/issues/12

GZGavinZhao commented 2 years ago

@jodinathan I'm not sure if you can see the details of the workflow run, but if you can, please fix the little formatting. You can simply run dart format . in the top level directory and it will format everything for you. Thanks!

GZGavinZhao commented 2 years ago

So far this looks good:

grinder running analyze

analyze
  Counting number of Dart files...
  Analyzing...
  100% Done!
  1 out of 298 files are still using deprecated API!
- [ ] material_input/material_input_multiline.dart

finished in 6.8 seconds

Just waiting for the CI to run one more time to make sure nothing breaks during the build.

jodinathan commented 2 years ago

fixed https://github.com/angulardart-community/angular_components/issues/24