search

angulardart-community / angular_components

High-quality Material Design components for AngularDart.
https://gallery.angulardart.xyz
22 stars 14 forks source link

StreamController are not closed. #59

Open jodinathan opened 2 years ago

jodinathan commented 2 years ago

While digging through the code I have noticed that the StreamController are not closed.

Ie date_input.dart: 

final _controller = StreamController<Date?>.broadcast();

Shouldn't we close it within ngOnDestroy to not have a memory leak?

I guess it would be better if we attach it into Disposer and let it clear the stuff.