search

angulardart-community / angular_components

High-quality Material Design components for AngularDart.
https://gallery.angulardart.xyz
22 stars 14 forks source link

Nuke unnecessary branches #74

Closed GZGavinZhao closed 2 years ago

GZGavinZhao commented 2 years ago

Ideally, there should be only two branches left: one is the dev branch, one is the main development branch that we migrate from null safety. Those who want to use it now with Angular 7 should use ngcomponents (the imports have not changed; just do a global find & replace package:angular_components -> package:ngcomponents).

I have been hesitant on this because renaming would mean that cross-referencing code between null-safety branch and dev branch might get harder. I think it's just me being lazy. However, after some consideration, I think renaming after the migration is done is going to be more problematic: if something bad happened during renaming, at least it will be found out during the migration; otherwise, we might have to spend a lot of time (or shot our future selves in the foot by) fixing unexpected bugs.

Probably can solve #71 at the same time.

dukefirehawk commented 2 years ago

I have a migrate\ngdart branch based on new-dev that had replaced all angular with ngdart and bumped dart to 2.17. About 5 more pending issues to resolve in examples due to analyzer upgrade and deprecated api. If you need this version for cross checking, let me know.

GZGavinZhao commented 2 years ago

@dukefirehawk That would be great. Thanks!

GZGavinZhao commented 2 years ago

Done. The current CI error is due to my migrating of lib/src/laminate/enums/alignment.dart (I need to update all the other files that utilize it as well) and is unrelated to branch and package renaming.