angulardart / angular

Fast and productive web framework provided by Dart
https://pub.dev/packages/angular
MIT License
1.83k stars 232 forks source link

Angular build option use_new_template_parser reported as invalid #791

Closed chalin closed 6 years ago

chalin commented 6 years ago

The 5.0.0-alpha+4 changelog reads:

  • We have a new template parser. . In order to use it, you need to set the following flag in your build.yaml:
    builders:
    angular:
    options:
      use_new_template_parser: True

But in doing so I get:

quickstart > pub run build_runner build
[INFO] ensureBuildScript: Generating build script...Unhandled exception:
Invalid argument(s): Got invalid options `[options]` for builder `angular`. Only `[builder_factories, import, build_extensions, target, auto_apply, required_inputs, is_optional, build_to, defaults]` are supported keys.
...

Note that I am using alpha+4:

quickstart > grep 5.0 pubspec.*
pubspec.lock:    version: "5.0.0-alpha+4"

Dart VM version: 2.0.0-dev.19.0 (Fri Jan 19 08:01:12 2018 +0100) on "macos_x64"

cc @kwalrath @kevmoo

alorenzen commented 6 years ago

This worked just fine for me on a hello world example: https://github.com/alorenzen/angular/commit/5de417a3faa388a8a6577027ea52d840fc6f1416

Just add an un-closed <div> tag to the HelloWorld component and see an error in the build.

matanlurey commented 6 years ago

@chalin maybe your config was wrong? It does look like it works.

chalin commented 6 years ago

Tried again (though on a clean setup), and I'm no longer getting the "invalid options" error. It could be that there was another error in the config, though the error message seemed to imply that it was because of an invalid option. Closing.