search

angulardart / angular_components

The official Material Design components for AngularDart. Used at Google in production apps.
https://pub.dev/packages/angular_components
372 stars 123 forks source link

Flat expansion panels jerk when opening #383

Closed timtraversy closed 3 years ago

timtraversy commented 5 years ago

This issue can be observed in the Angular Components gallery: https://dart-lang.github.io/angular_components/#/material_expansion_panel

When a flat expansion panel is opened, the opening animation jerks to completion. It looks like it is about to open smoothly, and then it just jumps, as if it its initial size calculation was mistaken.

Also, I can open a second issue for this, but expansion panels have a highlighted gray color after being dismissed. Is this intentional?

nshahan commented 5 years ago

cc @phantomesse

phantomesse commented 5 years ago

Hi Tim! Thank you for your feedback.

I'm not seeing the animation jerk for the flat expansion panels. Can you take a screencast?

The highlighted gray color indicates a focus state. When you've clicked on a panel to collapse it, it is highlighted in gray because it's still in focus.

timtraversy commented 5 years ago

Ok understood about the focus! Here's a video of the jerk I'm seeing: https://drive.google.com/file/d/1bTM4S_nSpoCCOfkZrtLuaHA1_mzMThIR/view?usp=sharing

It happens just as the animation is about to complete.

TedSander commented 5 years ago

@timtraversy what is your environment for that animation?

MacOS Chrome looks pretty smooth to me, but I definitely see it isn't smooth in the video.

timtraversy commented 5 years ago

Oh I see. I just tested on Mac Chrome and it looks fine there. I'm seeing the issue on Safari 12.1.

timtraversy commented 5 years ago

Is this planned to be supported on Safari?

TedSander commented 5 years ago

Pretty low priority for us compared to all the other things we are working on. I don't see us fixing it anytime soon.

On Sun, Apr 21, 2019, 6:49 PM Tim Traversy notifications@github.com wrote:

Is this planned to be supported on Safari?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dart-lang/angular_components/issues/383#issuecomment-485300968, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLB3XERV6FSF5GQQRJAS33PRUKSPANCNFSM4GSR3SAA .