search

angulardart / angular_components

The official Material Design components for AngularDart. Used at Google in production apps.
https://pub.dev/packages/angular_components
372 stars 123 forks source link

material-checkbox and material-radio labels are inconsistent #393

Open alescdb opened 5 years ago

alescdb commented 5 years ago

Hi everyone,

He is a simple loop that build a list of checkbox or radio :

<div *ngFor="let c of choices">
  <material-checkbox *ngIf="list.listType == 0" [label]="c.title" [checked]="c.defaultValue"></material-checkbox>
  <material-radio *ngIf="list.listType == 1" [checked]="c.defaultValue">{{c.title}}</material-radio>
</div>

My first instinct was to write both material-checkbox and material-radio the same way (either with label or in tag text) Nothing serious here, but it feels unnatural and inconsistent :-)

nshahan commented 5 years ago

We would like to fix these types of inconsistencies, but they come with a large cost of updating all of the locations in client applications where they are used. Those types of cleanups are not a high priority for us at the moment.