Closed ayushin closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
I signed it
Date.fromTime takes the timezone information from the time object itself. It is the responsibility for the passed time object to have the right timezone. This would break that functionality, and shouldn't be needed.
When the time UTC is in different date than time in local time, the dateTime setter will wrongly set the UTC date.
An easy fix is to pass
`tzOffset: DateTime().now().tzOffset
to Date.fromTime() (implemented) or convert _dateTime.toLocal() as the _dateTime might be/likely to be in UTC.