angulardart / angular_components

The official Material Design components for AngularDart. Used at Google in production apps.
https://pub.dev/packages/angular_components
372 stars 123 forks source link

[FIX] - tab indicator transform-origin issue in rtl sites #419

Closed hamidrezabstn closed 5 years ago

hamidrezabstn commented 5 years ago

according to #418 issue indicator tab has issue on rtl sites ! with this fix it will generate transform-origin dynamically base on isRtl flag from rtlToken!

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

hamidrezabstn commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

TedSander commented 5 years ago

We purposely don't use script to flip styles for RTL because it would slow everything down. As said in the bug we use CSSJanus to do this as part of our build step internally.

hamidrezabstn commented 5 years ago

We purposely don't use script to flip styles for RTL because it would slow everything down. As said in the bug we use CSSJanus to do this as part of our build step internally.

please see #418 again! Thanks!