ChangeDetectionStrategy.OnPush missing in a few components

angulardart / angular_components

The official Material Design components for AngularDart. Used at Google in production apps.

https://pub.dev/packages/angular_components

374 stars 123 forks source link

Open vlin59 opened 3 years ago

vlin59 commented 3 years ago

I'm on angular: 6.0.0 and angular_components: 1.0.1.

Using the MaterialSelectComponent gives this compile-time warning when the parent uses the OnPush Change Detection Strategy.

"MaterialSelectComponent" doesn't use "ChangeDetectionStrategy.OnPush", but is used by a component that does.

ReorderListComponent and MaterialSelectSearchboxComponent appears to also require it.

I haven't come across anything else in my codebase but more could be missing.

GZGavinZhao commented 2 years ago

Fixed in the latest, Angular-7-compatible ngcomponents