Closed faraway closed 8 years ago
@patrickyao1988 Awesome man, I'll take a look soon. In the meantime could you please squash your commits? I think having 2 or 3 total would be ok, just to keep a clear history log.
@m00s Thank you so much for reviewing. There're still a few things i want to improve, and i will also add more tests (ooops... sounds like TDD violation..). I will absolutely squash the commits when i'm done : )
@patrickyao1988 Awesome, the code looks good to me, when you're done let me know.
This PR is replaced by https://github.com/andreareginato/oauth-ng/pull/109 so that we will have a cleaner commit history. Closing...
OpenID Connect is built on top of OAuth2, This PR is trying to implement the Implicit Flow(Per http://openid.net/specs/openid-connect-core-1_0.html#ImplicitFlowAuth)
Flow wise there's actually not much change. The major changes (as opposed to regular OAuth2) are:
scope
is usuallyopenid
, andresponse_type
is eitherid_token
orid_token token
. e.g.2.When getting successful auth response: Besides the other values that OAuth2 would have, it will have one more
id_token
, which is a JWT format token. e.g.It definitely needs more documentation and automation test coverages(probably even more manual testings). @andreareginato @m00s I'm just trying to see if you guys would be interested in such a feature, and hoping to get some comments / suggestions at the same time.