search

angularjs-oauth / oauth-ng

AngularJS directive for the OAuth 2.0 Implicit Flow
http://angularjs-oauth.github.io/oauth-ng/
MIT License
363 stars 156 forks source link

Error thrown by cancelExpiresAtEvent function #126

Closed mike-tempest closed 8 years ago

mike-tempest commented 8 years ago

cancelExpiresAtEvent uses $timeout, but it is not injected into the AccessToken factory causing a block error to be thrown.

Easy way of replicating error being thrown is run AccessToken.setTokenFromString(hash). I have created a pr for the fix as this is blocking us from a release of a new oauth integration in our app.

PR for fix https://github.com/angularjs-oauth/oauth-ng/pull/125

mike-tempest commented 8 years ago

@m00s would be good to get this in soon

m00s commented 8 years ago

Hi @mike-tempest, the same fix was merged with the PR #124. I just released v0.4.9

Closing this