Switching token == nil -> Login instead of logout (should make SSO situations work more seamlessly)

angularjs-oauth / oauth-ng

AngularJS directive for the OAuth 2.0 Implicit Flow

http://angularjs-oauth.github.io/oauth-ng/

MIT License

363 stars 156 forks source link

Switching token == nil -> Login instead of logout (should make SSO situations work more seamlessly) #131

Closed piotrb closed 7 years ago

piotrb commented 8 years ago

This basically switches the behaviour when there is no token found, to attempt to hit the auth service to get it as opposed to forcefully logging out. This had the inadvertent effect of preventing a seamless SSO handoff between apps if you don't have a session, you'd be FORCED to log in again even if you just logged in.

bramski commented 8 years ago

Could somebody respond please?

bramski commented 8 years ago

@piotrb can this be tested?

piotrb commented 8 years ago

Not sure .. I can't even get the dev dependancies to install on modern node :(

bramski commented 7 years ago

Pretty trivial change. Merging.