search

angularsen / UnitsNet

Makes life working with units of measurement just a little bit better.
https://www.nuget.org/packages/UnitsNet/
MIT No Attribution
2.19k stars 380 forks source link

Add quantity for Impulse (integral of force over time) #1139

Closed Sigvess92 closed 1 year ago

Sigvess92 commented 2 years ago

We are using UnitsNet to handle force plate data and derived metrics. We utilize quantities such as Force, Torque and ForceChangeRate, but have not been able to figure out what to do with impulse data (integral of force over time). Creating and maintaining our own impulse type is not optimal, especially if it could also be of use to others by adding it to the main repo.

Does a suitable quantity for impulse exist already under a different name? Is there a reason why such a quantity doesn't/shouldn't be a part of UnitsNet or can it be added? I could contribute with a PR on this request if accepted.

Brunni commented 2 years ago

Did you check https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit for further information?

Sigvess92 commented 2 years ago

Did you check https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit for further information?

Yes, and it seems to me that it should tick all the boxes in the "A quantity is a good fit to add" section. Did you mean to refer to a specific point in the document?

angularsen commented 1 year ago

@Sigvess92 Sorry for the late reply, I have been missing out on email notifications for some time.

I think Impulse is a great fit, please go ahead with the PR.

What units do you propose?

I see some common ones here: https://www.translatorscafe.com/unit-converter/en-US/impulse/

Sigvess92 commented 1 year ago

@angularsen Great! Will hopefully get it prioritized soon.

Newton seconds is by far the most common unit, but it is probably a good idea to include everything in the source you linked.

Sigvess92 commented 1 year ago

@angularsen Created PR: https://github.com/angularsen/UnitsNet/pull/1178

I decided to only add the units that were used in systems of quantities relevant to the field of mechanics. The site you linked also included unrelated but dimensionally equivalent units which I decided to skip.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

angularsen commented 1 year ago

Merged by #1178