search

angularsen / UnitsNet

Makes life working with units of measurement just a little bit better.
https://www.nuget.org/packages/UnitsNet/
MIT No Attribution
2.65k stars 382 forks source link

Add units for Molality #1341

Closed peterjamesnugent closed 11 months ago

peterjamesnugent commented 11 months ago

Closes #1340

Added conversion for Molality covering the following units:

peterjamesnugent commented 11 months ago

@angularsen I have added the JSON, but running in to issues with the generate-code.bat

I have installed .NET 6.0 SDK (v6.0.320) - Windows x64 and running the .bat does not appear to do anything. Some code appears to pop up, but the terminal window closes almost instantly before I get a chance to read it.

Any ideas?

angularsen commented 11 months ago

@peterjamesnugent Open the bat file in a text editor, and you will see the command it tries to run. I typically use Git for Windows bash shell and run generate-code.sh, but the two scripts basically do the same thing.

Try to run this manually and see what output you get. Should work from both Git Bash, Windows Powershell and Windows Commandline, whichever you have available.

# From UnitsNet repo directory
dotnet run --project CodeGen
angularsen commented 11 months ago

Looks perfect to me. Nicely done!

Nuget should be out shortly.

Release UnitsNet/5.40.0 · angularsen/UnitsNet