search

angularsen / UnitsNet

Makes life working with units of measurement just a little bit better.
https://www.nuget.org/packages/UnitsNet/
MIT No Attribution
2.65k stars 382 forks source link

Add new unit conversion for mmol/kg #1402

Closed Martian42 closed 4 months ago

Martian42 commented 4 months ago

Is your feature request related to a problem? Please describe. Add Molality unit prefix for millimole per kg (mmol/kg)

Describe the solution you'd like Add SI unit conversion to the relevant existing Json files from new units descripted above.

Describe alternatives you've considered The units are not covered by the existing UnitNet, but they are within existing Json files.

Additional context Happy to write the code and raise a PR if you agree it's worth adding. They are units type already considered in Unitnet but simply adding to the range of conversion capability. All units above are commonly used world wide for a wide ranges of field.

Martian42 commented 4 months ago

Please note μS/cm, mg/L is already in UnitNet. I can't change the name of the issue.

@angularsen I'm ready to push PR if you are ok with me adding prefix to Molality unit 😃

I don't have writing right at the moment.

angularsen commented 4 months ago

Sorry for late reply, I replied in #1403