search

angulartics / angulartics-google-analytics

Google Analytics plugin for Angulartics
MIT License
133 stars 86 forks source link

peerDependencies change/fix is a breaking change #28

Closed robations closed 8 years ago

robations commented 8 years ago

The commit "move angulartics to peerDependencies" is a breaking change in that you can't upgrade without fixing some code in a dependent project.

So under semantic versioning this probably should have been a minor version change for 0.x numbers, eg 0.1.2 --> 0.2.0 rather than 0.1.2 --> 0.1.3. But the horse has already bolted.

robations commented 8 years ago

But the horse has already bolted.

closing! :)