There should be a check in setDimensionsAndMetrics if properties is null

angulartics / angulartics-google-analytics

Google Analytics plugin for Angulartics

MIT License

133 stars 86 forks source link

There should be a check in setDimensionsAndMetrics if properties is null #33

Closed gligoran closed 8 years ago

gligoran commented 8 years ago

The properties set by $analytics aren't used solely by angulartics-google-analytics, so null can be a valid entry for setUserProperties, which maps to setDimensionsAndMetrics in this plugin.

If null is passed now, this exception is thrown:

Cannot read property 'dimension1' of null