search

angulartics / angulartics-google-analytics

Google Analytics plugin for Angulartics
MIT License
133 stars 86 forks source link

Rename angulartics-google-analytics.js to angulartics-ga.js #34

Closed timlevett closed 8 years ago

timlevett commented 8 years ago

Similarly to how one fixed https://github.com/angulartics/angulartics/issues/58 this change should Resolve #13.

vertein commented 8 years ago

:+1: Thanks @timlevett! This would help us out a lot.

apetro commented 8 years ago

:+1: . Would resolve a hang-forever-loading graceless failure in MyUW.

hamdrew commented 8 years ago

This will break again if the ad blocker blacklists are updated to include angulartics-ga.js. I'm not really sure what other solution there is, though.

timlevett commented 8 years ago

The adblock program blocks anything that contains google_analytics. You are correct, if they start blocking ga then we could be hurting, but ga seems generic enough that it may create other issues for them.

timelf123 commented 8 years ago

I'll cut a release ASAP with this change. If you run into blacklist issues again, please file a new issue. Thanks!

timlevett commented 8 years ago

Thanks for the update @timelf123 . We very much look forward to the new release.

blindstuff commented 8 years ago

Has this been added to a release yet? I'm installing from bower and I'm getting the old naming unless I install a specific commit.

darkmavis1980 commented 8 years ago

I'm having the same issue, I guess it's also the folder name that gives the issue

timlevett commented 8 years ago

Interesting, I can check with our support, see if they are still getting cases.

blindstuff commented 8 years ago

@timlevett I was also getting this error, the folder name is blocked as well.

@darkmavis1980 you can work around it by using a build process to rename or to combine multiple library dependencies, but if you do a direct install from bower, it will get blocked.