angulartics / angulartics-google-analytics

Google Analytics plugin for Angulartics
MIT License
133 stars 86 forks source link

Refactor, added Classic User TImings, added duplication configs, added docs #71

Closed DanWilkerson closed 8 years ago

DanWilkerson commented 8 years ago

Refactored core code to use a single handler for dispatching hits (dispatchGaHit) and remove the need to check the version in each individual api handler. Changed the model to format every hit in the UA style and then transpose to the Classic style in the handler.

Added a configuration option to specify which hits to duplicate/not duplicate. Defaults are set to mirror current default behavior.

Bumped minor to 0.3.0. Will need to re-bump if #67 is accepted before/after.

Should close #46, #69, #70, and #26.

timelf123 commented 8 years ago

Whoops, merged the transaction one already. LGTM after conflicts solved. Can these two just share the same minor?

DanWilkerson commented 8 years ago

@timelf I'd like to adjust the ecommerce code to use the same dispatchToGa and additionalAccountsHitTypes w/ this PR. Can I push another commit tonight without bumping, you think?

timelf123 commented 8 years ago

Sounds good to me since we haven't published anything to npm or pushed any tags

DanWilkerson commented 8 years ago

Dug myself in a bit of a hole here without realizing it - may take another day to get this ironed out.

DanWilkerson commented 8 years ago

Okay, take a look and let me know if it's good to merge in @timelf123

timelf123 commented 8 years ago

Still conflicts with master @DanWilkerson

DanWilkerson commented 8 years ago

Whoops, so there are. Fixed and merged!

timelf123 commented 8 years ago

Does this need to be built/tagged/published?

DanWilkerson commented 8 years ago

Yes, does need to be published - I rebuilt before pulling this in, though. I have a release drafted with these notes: v0.3.0

LGTY? I can publish immediately.

timelf123 commented 8 years ago

LGTM @DanWilkerson

Nice work