search

angulartics / angulartics-mixpanel

Mixpanel plugin for Angulartics
MIT License
34 stars 27 forks source link

Bower Main Should Point At Non-Minified Version #22

Closed mtpultz closed 8 years ago

mtpultz commented 8 years ago

Bower main is for automated tooling and shouldn't be the minified version since the tooling is typically set on --production to minify all dependencies, but as is the minified file will be reminified.

Incidentally I only noticed this since there is an issue with the minified version on master, which I'm using to get this callback #18. Appears to be related to eventTrack's properties parameter being undefined, but there's no issue using the non-minified version. Might be related to PR #19.

mtpultz commented 8 years ago

I updated bower.json and pushed a PR #23

timelf123 commented 8 years ago

merged, will cut a release asap

mtpultz commented 8 years ago

Thanks @timelf123 will look for the release

mtpultz commented 8 years ago

Hi @timelf123 sorry to bug you. Is it possible to cut a minor release that includes these changes so we don't have to work off master in case of any breaking changes introduced during development.

timelf123 commented 8 years ago

Built and pushed, sorry for delay