search

angulartics / angulartics-mixpanel

Mixpanel plugin for Angulartics
MIT License
34 stars 27 forks source link

Register new method for logout #9

Open marbiano opened 8 years ago

marbiano commented 8 years ago

It's a good technique clear mixpanel cookies when you have a user logging out. That can be done with mixpanel.cookie.clear();. Now, I tried to add a new method to the waitForVendorApi callback, but I just got an error that I'm sure comes from the method not being defined in the original Angulartics library.

I would be happy to provide a PR for this functionality, but I need some guidelines whether I should first create a PR in the original library. Could you help me?

GMoHughes commented 8 years ago

Any updates on this? Also happy to create a pull request. mbavio did you solve your issue?

marbiano commented 8 years ago

@GMoHughes I did this update on my fork but then couldnt find time to take care of this main repo, I'm too busy getting into React and trying to not get back to Angular again! 😂

GMoHughes commented 8 years ago

@mbavio This is the worst news - you have the best (one of the only) libraries for SPA so far! If I pull request for cookies clear will you merge and bump it? :)

A final treat for angular haha

marbiano commented 8 years ago

@GMoHughes For sure!

marbiano commented 8 years ago

@GMoHughes Ups, I have no idea why but I made a mistake and thought we were talking about another project. I'm not a maintainer of this repo so I can't merge your PR!

timelf123 commented 8 years ago

I can merge your PR when you publish it

GMoHughes commented 8 years ago

@timelf123 Need write permissions?

timelf123 commented 8 years ago

Hi there @GMoHughes - I'm happy to review your PR after you post it

GMoHughes commented 8 years ago

I don't have permissions to write - have tried pushing to remote. Or is it something on my side?

timelf123 commented 8 years ago

@GMoHughes you should push your changes to a branch of your fork (click fork button above), then a PR button will come up https://help.github.com/articles/creating-a-pull-request/

GMoHughes commented 8 years ago

Have made two pull requests. The first is correcting the current userTimings function, i've tested it on my side and the parameters only work with action, properties. Else the time does not record.

This also works with current implementation in angulartics-google-analytics

The second is for the cookies.clear method

Thanks! Can you let me know when the version is bumped too?

GMoHughes commented 8 years ago

@timelf123 Hi. I have made a couple of pull requests just over a fortnight ago, could you have a look?

If we can't merge and bump version anytime soon could you let me know as i'll write the library up in-house

Thanks G