npm - missing .js files

[NathanWalker]

Looks like with 1.0.3 just published, it's now missing the src/providers/*.js files... the .js.map files are there but no .js files resulting in errors. From a fresh install with latest:

[NathanWalker]

I believe the reason is because the .ts is missing in this: https://github.com/angulartics/angulartics2/blob/master/tsconfig.json#L22-L25

[JonnyBGod]

Yes just realised it. Not sure why but tsc -d is not creating the .js files. Tried your tip but no luck.

[NathanWalker]

That PR will fix it... definitely generates the .js for those files now for me locally.

[NathanWalker]

Btw, if you want to add me as collaborator here and on npm for this, I can help with this kind of stuff in the future.

[JonnyBGod]

Sure will ask for you to be added. Just need to ask angularitics guys. Thanks for your help.

[JonnyBGod]

Files are still missing from latest build.

[NathanWalker]

They are still not there, I see that with 1.0.4, very strange. Are they there when you build and before you publish?

[NathanWalker]

Basically:

npm run build

Look in src/providers, are the .js files there?

If yes, bump version, then:

npm publish

Should do it.

If there are not there, then there must be errors resulting when running npm run build that are preventing the provider files from compiling?

[JonnyBGod]

npm run build is working locally

Release process should work with semantic-release in travis.

[NathanWalker]

I think this: https://github.com/angulartics/angulartics2/pull/19 will finally solve it.

[JonnyBGod]

I am up for trying any idea at this point. :/

[NathanWalker]

Ok I didn't know you are relying on sematic release, you will need to change this then in package.json:

"semantic-release": "semantic-release pre && npm publish && semantic-release post"

I would have added that in my PR... anyway just change that ^ to this...

"semantic-release": "npm run build && semantic-release pre && npm publish && semantic-release post"

pretty sure that would do it

[JonnyBGod]

Oh yes that should be it.

Thanks again.

[NathanWalker]

Well wow still not it. Ok it takes a lot, and I mean a lot to make me quit, so we will solve this thing... maybe it needs this:

"semantic-release": "semantic-release pre && npm run build && npm publish && semantic-release post"

May require pre be first.

[JonnyBGod]

trying it.

[NathanWalker]

Hooray!! it worked!

[NathanWalker]

Well we both learned something very important 👍

[JonnyBGod]

Great!! Yes now I can fix two other libraries. Big thanks.

[NathanWalker]

I need to start using semantic-release myself but yeah I guess it's paramount that pre be the first out the gate to execute (which makes sense if you think about it)... anyhow, this looks much better now! And I love this lib, so def wanna make it as tight as possible!

[JonnyBGod]

Sorry about these bugs... I am very new to all this (angular2, observables, typescript...) learning all atm. I am bound to make these mistakes at first. Good to have some help :)

[NathanWalker]

N/p at all, I'm new to them as well and have been making mistakes myself in several places. The idiosyncrasies with publishing and developing the lib make for some serious confusion at times. We're getting there! ... together 👍

[JonnyBGod]

Added you as collaborator.

[NathanWalker]

Thx! I'll help tighten and review when I can and as always would put stuff up for review before making any changes, cheers!

[JonnyBGod]

Can you talk (https://gitter.im/angulartics/angulartics2) one minute? I would like to run an issue through you.