codecov-io
commented
4 years ago Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@22fc83e). Click here to learn what that means. The diff coverage is64.28%.
@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage ? 75.15%
=========================================
Files ? 32
Lines ? 821
Branches ? 150
=========================================
Hits ? 617
Misses ? 134
Partials ? 70| Impacted Files | Coverage Δ | |
|---|---|---|
| src/lib/providers/adobeanalytics/adobeanalytics.ts | 54.54% <64.28%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 22fc83e...a4de39b. Read the comment docs.
jtinsman-mgage
What kind of change does this PR introduce? Adds additional properties to Page Track and also add ability within Adobe Omniture provider to override page name and not be forced to use the site URL.
What is the current behavior? Link to open issue? Not able to add additional parameters to page tracking https://github.com/angulartics/angulartics2/issues/351
What is the new behavior? page tracking allows passing of additional parameters and adobe can override page name from the url
Note, I am using Angular 5 and Angulartics2 v5.4.0 but those are only tags and not branches so it would be nice if the previous major release versions could have an updated branch so that they can have this feature to.