feat(Piwik): setCustomUrl missing the port info from the URL; se…

[shahmirn]

…

• What kind of change does this PR introduce? Fixes a couple of bugs with the Piwik tracker:

• Port was missing from the URLs being sent to Matomo. So, in the case of local development, Matomo was showing localhost/ instead of localhost:/

• The Matomo API for setCustomVariable is

setCustomVariable(index, name, value, scope = "visit")

and the example in their documentation is

_paq.push(['setCustomVariable',
    // Index, the number from 1 to 5 where this custom variable name is stored
    1,
    // Name, the name of the variable, for example: Gender, VisitorType
    "Gender",
    // Value, for example: "Male", "Female" or "new", "engaged", "customer"
    "Male",
    // Scope of the custom variable, "visit" means the custom variable applies to the current visit
    "visit"
]);

passing an object to setCustomVariable doesn't work.

• What is the current behavior? Link to open issue?

• setCustomVariable doesn't work. https://github.com/angulartics/angulartics2/issues/101 fixed the issue of setting custom dimensions, but custom variables are still broken.

• port number is missing when setting URL

• What is the new behavior?

• setCustomVariable sets the data correctly

• port number is present when setCustomUrl is called

[shahmirn]

Also, this is potentially a breaking change, so we should bump the version number.

[codecov-io]

Codecov Report

Merging #368 into master will decrease coverage by 0.15%. The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   75.21%   75.06%   -0.16%     
==========================================
  Files          32       32              
  Lines         815      818       +3     
  Branches      147      149       +2     
==========================================
+ Hits          613      614       +1     
- Misses        133      135       +2     
  Partials       69       69

Impacted Files	Coverage Δ
src/lib/providers/piwik/piwik.ts	73.01% <40%> (-3.66%)	:arrow_down:
src/lib/providers/ga/ga.ts	64.04% <0%> (+1.12%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1d75ce...6e714a2. Read the comment docs.

[scttcper]

:tada: This PR is included in version 8.2.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: