angulartics / angulartics2

Vendor-agnostic analytics for Angular2 applications.
MIT License
1.01k stars 193 forks source link

Wrong type for setUsername #394

Open nigelsim opened 4 years ago

nigelsim commented 4 years ago

For support questions, please consider using Gitter - Chat

I'm submitting a ...

The Angulartics2 service has a replay subject, setUsername that takes the type { userId: string | number } | string. However, none of the providers accept this type. They all accept only string.

Types to match

Invalid user identifiers have been sent through to MixPanel.

please run the following and copy the output

Angular CLI: 9.1.9
Node: 10.19.0
OS: linux x64

Angular: 9.1.11
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, upgrade
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.25
@angular-devkit/build-angular     0.803.25
@angular-devkit/build-optimizer   0.803.25
@angular-devkit/build-webpack     0.803.25
@angular-devkit/core              8.3.25
@angular-devkit/schematics        9.1.9
@angular/cli                      9.1.9
@ngtools/webpack                  8.3.25
@schematics/angular               9.1.9
@schematics/update                0.901.9
rxjs                              6.6.2
typescript                        3.9.7
webpack                           4.43.0