search

anhaidgroup / py_entitymatching

BSD 3-Clause "New" or "Revised" License
183 stars 48 forks source link

Fix macos from source #129

Closed christiemj09 closed 4 years ago

christiemj09 commented 4 years ago

The build on macOS from source has been broken for a while now. It's because recent versions of conda have dropped gcc as an available package (there are other related packages):

# Known version of conda with gcc available
docker container run --name conda4.4 continuumio/miniconda:4.4.10 conda search gcc

# Latest version of conda
docker container run --name condalatest continuumio/miniconda:latest conda search gcc

This PR simply drops the conditional installation of gcc on macOS; the latest macOS instances on Travis have gcc installed.

NOTE: As a temporary solution, this PR also contains pinned numpy and scikit-learn versions prior to installing dependencies. This is currently necessary in order to support Python 2.7 and to avoid #127. A long-term solution should fix #127 and drop support for Python 2.

jatinarora2409 commented 4 years ago

This is a temporary fix, where we hardcode the old versions of NumPy and sckit-learn. We should work on making the entity matching module.