search

anhaidgroup / py_entitymatching

BSD 3-Clause "New" or "Revised" License
183 stars 48 forks source link

extract_feature_vecs() issue with cloudpickle + Fix #140

Open Stochastic-Squirrel opened 4 years ago

Stochastic-Squirrel commented 4 years ago

Hello, I am using Python 3.7 and cloudpickle 1.5.

When i ran the extract_feature_vecs() function it yielded an error stating that cloudpickle has no attribute "dumps"

Below is symbolically what I was running

`import py_entitymatching as em

matching_features_df = em.extract_feature_vecs(candidate_table, feature_table = matching_features, show_progress = False)`

All I had to do to change this was change "from cloudpickle import cloudpickle" to "import cloudpickle"

On line 14 of extractfeatures.py and it solved my issue :)

Great package and I thought I would let others know of this fix.

christiemj09 commented 3 years ago

@Stochastic-Squirrel Thanks for catching this! See fix in PR above.