search

anhaidgroup / py_entitymatching

BSD 3-Clause "New" or "Revised" License
184 stars 48 forks source link

feature extract methods for numeric data fail when predict term #80

Open haisland0909 opened 7 years ago

haisland0909 commented 7 years ago

In sim_functions.py method abs_norm and rel_diff which is for numeric data fail when the predict data has string type row.

anhaidgroup commented 7 years ago

@haisland0909 . Are you referring to RIT features branch or the main branch?. There are some changes happening in the Main branch now. Yes, I plan to fix that numeric feature to work for string attrs.

anhaidgroup commented 7 years ago

Ok. I see now. Thanks for the pull request. I will merge in the changes.

haisland0909 commented 7 years ago

Yeah! Cause I'm now using RIT_feature for xgboost.