Enhan jaro cython - Githubissues

anhaidgroup / py_stringmatching

A comprehensive and scalable set of string tokenizers and similarity measures in Python

https://sites.google.com/site/anhaidgroup/projects/py_stringmatching

BSD 3-Clause "New" or "Revised" License

136 stars 16 forks source link

Enhan jaro cython #40

Closed SrujithPoondla closed 7 years ago

SrujithPoondla commented 7 years ago

-- Added code for benchmarks in benchmarks directory -- Added a new directory for benchmark results -- Moved cython_levenshtein to new directory py_stringmatching/cython -- Added cython code for Jaro and Jaro Winkler measures --Changed unit tests for Generalized Jaccard and Monge Elkan --Modified the get_raw_score function in Generalized Jaccard and Monge Elkan to return a floating point number up to 5 decimal places -- Ran nosetests successfully

coveralls commented 7 years ago

Coverage decreased (-0.003%) to 99.907% when pulling 8147711e42063f1022f59d88069e2ae1fba8f1f9 on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.

coveralls commented 7 years ago

Coverage decreased (-0.003%) to 99.907% when pulling 8147711e42063f1022f59d88069e2ae1fba8f1f9 on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.

coveralls commented 7 years ago

Coverage decreased (-0.003%) to 99.907% when pulling 8147711e42063f1022f59d88069e2ae1fba8f1f9 on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.

coveralls commented 7 years ago

Coverage decreased (-0.003%) to 99.907% when pulling 8147711e42063f1022f59d88069e2ae1fba8f1f9 on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.

paulgc commented 7 years ago

@SrujithPoondla

Remove all .DS_Store files, csv, xlsx files
Move py_stringmatching/cython to py_stringmatching/similarity_measure/cython

SrujithPoondla commented 7 years ago

Removed all csv, xlsx and .DS_Store files and also changed the cython directory.

coveralls commented 7 years ago

Coverage decreased (-0.003%) to 99.907% when pulling 09ba51a1c3c52d1edd58af22509964850c7b28db on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.

coveralls commented 7 years ago

Coverage increased (+0.09%) to 100.0% when pulling 09ba51a1c3c52d1edd58af22509964850c7b28db on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.

anhaidgroup commented 7 years ago

@SrujithPoondla

Still a couple of .DS_Store files are present
Can you remove the benchmark code from this branch ? You can create a separate branch called 'bench_sim_measures' and add the benchmark code in that branch.

coveralls commented 7 years ago

Coverage decreased (-0.003%) to 99.907% when pulling 88592022a3d7f613b7a605210d7dccb250e905b6 on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.

coveralls commented 7 years ago

Coverage decreased (-0.003%) to 99.907% when pulling 31d78d29c642a747eee15a1e1ed3267251e0f022 on enhan_jaro_cython into 05315a0c5e06ddb6f8412fe88e56a5df7015e221 on master.