search

anhaidgroup / py_stringmatching

A comprehensive and scalable set of string tokenizers and similarity measures in Python
https://sites.google.com/site/anhaidgroup/projects/py_stringmatching
BSD 3-Clause "New" or "Revised" License
135 stars 16 forks source link

setup.py: Lazy evaluate if pip is needed #49

Closed AbdealiLoKo closed 1 year ago

AbdealiLoKo commented 6 years ago

If pip is not needed (all required modules are alreay installed) then do not throw an error if pip is not installed.

This makes it difficult to make packages like conda packages.

AbdealiLoKo commented 6 years ago

Was making a conda package in conda-forge for this and realized that this is an issue as it assumes pip to be installed even when not required

https://github.com/conda-forge/staged-recipes/pull/4650

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.903% when pulling 0ee19697b91e79e28b8c673c709cec4b9b3e7a17 on AbdealiJK:ajk/setup into 9c7be1082f8c7b5a9de48b0bcdce4b60acbfa38f on anhaidgroup:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.903% when pulling 0ee19697b91e79e28b8c673c709cec4b9b3e7a17 on AbdealiJK:ajk/setup into 9c7be1082f8c7b5a9de48b0bcdce4b60acbfa38f on anhaidgroup:master.