search

anharmonic / d3q

D3Q + thermal2
Other
22 stars 12 forks source link

Remove QE CMake patch. #4

Closed ye-luo closed 2 years ago

ye-luo commented 2 years ago

Before adding d3q as a gitsubmodule in QE https://gitlab.com/ye-luo/q-e/-/tree/add-d3q Need to update d3q side a bit.

  1. Upstream QE has moved the definition of customized target of each internal/external library into their own CMakeLists.txt. So need to add just d3q accordingly.
  2. Since QE will take care of connecting d3q part. There is no need to patch QE CMake.
paulatz commented 2 years ago

Thank you Ye Luo, I cannot really test it at the moment as I'm working on an old borrowed PC, but I don't see how it could not work