Start of the code review process 👋

[malparty]

Hello Tiến, 👋

Thank you for your effort on the code submission. I am Xavier Malparty, Team Lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process. That said, additional code changes are not needed.

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

[anhdt1911]

Hello Xavier,

Thank you for taking your time to review my submission. 🙇🏼

Sorry for the late reply. I'm in process of moving to a new apartment so I haven't got time to check my github.

I notice you stated that no additional code required. But the issues still need to be address by code right? I'm a bit confuse. Please help to elaborate on this.

[anhdt1911]

I have reviewed all the issues and have provided the necessary directions to address them. However, as mentioned above ☝️, can we reschedule slightly? I will implement the fixes on Monday morning once I have settled in after my move. 🙏🏼. Thank you!

[malparty]

Hi @anhdt1911

As mentioned, no need to implement the fixes, the issues created are for discussion and providing feedback ;-)

Thanks for all your answers, I'll read them now ~