search

anhility / BestInSlotRedux

A fork and continuation of the BestInSlot WoW addon.
MIT License
2 stars 15 forks source link

Valid non-specc assigned items are filtered out #32

Open Nitrodroki opened 6 years ago

Nitrodroki commented 6 years ago

151972 [Sullied Seal of the Pantheon] 151973 [Collar of Null-Flame]

are jewelry and is filtered-out by all specs.

I believe it resides in the statfilters of the core at the line 860, might be wrong can't test it right now

     canUse = tContains(statFilter, specializationId)
      end
    else
      canUse = replace false by true
Meivyn commented 6 years ago

Can confirm it. I noticed it yesterday after killing hounds and noticed this neck is better for me than the one I've found in BestInSlot.

Nitrodroki commented 6 years ago

An inelegant solution but temporary one is to warn your guild that for rings and amulets, those items need to be set on "show all items" and it'll show them but it'll need to be fixed in the future =)

anhility commented 6 years ago

If canUse is set to true so would it not filter at all for any spec. The problem is more that the addon relies on items being assigned to be used with certain speccs and filter out all other specs and in this case "neutral" items without any specc associated. I've to go through that function of the code and see if I can add "neutral" items to the filter list.