Use isatty(1) to use plain output if skipfish is redirected to file

[GoogleCodeExporter]

SSIA. The screen output is quite pretty, you
might as well do similarly pretty output if
skipfish is redirected.

Original issue reported on code.google.com by n3npq....@gmail.com on 5 Jul 2010 at 1:46

[GoogleCodeExporter]

Not sure there's that much of a point in redirecting stdout (it's akin to 
redirecting the output of mc or vim)... people interested in a real-time log 
can use debug output instead... but will think about it.

Original comment by lcam...@gmail.com on 5 Jul 2010 at 2:09

• Added labels: Type-Enhancement, Priority-Low
• Removed labels: Type-Defect, Priority-Medium

[GoogleCodeExporter]

Note that a Mac OS X black-on-white terminal is what
led to redirecting stdout/stderr. Skipfish may be
WYSIWYG like mc/vi but it sure is hard reading skipfish output
grey-on-white. Sure I could "fix" in many ways,
I'm just lazy and my tired old eyes hurt when I squint.

Not complaining, I understand the issues perfectly.

Original comment by n3npq....@gmail.com on 5 Jul 2010 at 2:27

[GoogleCodeExporter]

Oh, you can fix it in a much easier way, documented here:

http://code.google.com/p/skipfish/wiki/KnownIssues

...namely, disable USE_COLORS in config.h, or use -u to inhibit stdout junk 
altogether.

Original comment by lcam...@gmail.com on 5 Jul 2010 at 3:05

[GoogleCodeExporter]

I saw USE_COLORS, thanks for the pointer. The difference is that isatty would 
make
the "fix" run-time adaptable, not compile time.

But its not a very important issue.

Original comment by n3npq....@gmail.com on 5 Jul 2010 at 3:12

[GoogleCodeExporter]

I'm closing this out. I understand the benefit and would be happy to accept a 
patch ;-) Note however that besides replacing USE_COLORS, this would also 
require the color macro's to be changed.

Original comment by niels.he...@gmail.com on 3 Aug 2012 at 1:40

• Changed state: WontFix
• Added labels: Usability