anhoej / qicharts2

R package: Quality improvement charts
38 stars 12 forks source link

Allow user to get data prior to plotting function #30

Closed rjake closed 3 years ago

rjake commented 3 years ago

We're making great use of qicharts2 on our team and we would benefit from being able to get the prepared data prior to the plot. Right now we frequently call qic(...)$data but it takes longer as it goes the the step of creating the plot. If you're open to it, I'm happy to submit a PR.

https://github.com/anhoej/qicharts2/blob/b938510557b81a97795c1172c5a4a7b44fa3fdeb/R/qic.R#L267-L268 In line 269 we could have:


if (return_data = TRUE) {
  return(d)
}
anhoej commented 3 years ago

thanx, go ahead. No promises made. I'll need to check carefully for unwanted side effects :-)

Den man. 14. jun. 2021 kl. 17.41 skrev Jake @.***>:

We're making great use of qicharts2 on our team and we would benefit from being able to get the prepared data prior to the plot. Right now we frequently call qic(...)$data but it takes longer as it goes the the step of creating the plot. If you're open to it, I'm happy to submit a PR.

https://github.com/anhoej/qicharts2/blob/b938510557b81a97795c1172c5a4a7b44fa3fdeb/R/qic.R#L267-L268 In line 269 we could have:

if (return_data = TRUE) { return(d) }

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/anhoej/qicharts2/issues/30, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCD7RFZLTPWWFX64PUN2O3TSYPKZANCNFSM46VPSVYA .

-- Venlig hilsen Jacob Anhøj