search

anhoej / qicharts2

R package: Quality improvement charts
38 stars 12 forks source link

Add option for 95% (2 Sigma) limits #33

Closed andrjohns closed 2 years ago

andrjohns commented 2 years ago

Hi Jacob,

This PR adds the calculation of and option to show 2 sigma limits on the generated SPC plot. The option is off by default, so there should be no changes to existing behaviour.

The testthat .rds references will need to be re-generated to include the output of the 95% limits, but I've just excluded those limits from the tests at the moment so that you can see that all existing tests pass.

Let me know if I've missed anything.

Thanks! Andrew

andrjohns commented 2 years ago

Yep! No changes to rules or checking. This just adds the 2 sigma limits to the dataframe, plot, and summary

anhoej commented 2 years ago

Thanks. Good idea. I'll have a closer look.

anhoej commented 2 years ago

Looks good. May I suggest you add 3s lines in the same colour as 2s lines, when show.95 = T. That would make it easier not to misinterpret 2s lines as 3s, which is a risk when 3s is only shown as gray background. Try options(cl.shade = F) to see what I mean.