search

anhthang / soap-converter

Transform SOAP/WSDL descriptions to other formats
MIT License
22 stars 8 forks source link

Add command line arguments for bash mode #5

Closed er1c closed 4 years ago

er1c commented 4 years ago

Also fixes being able to use ~/output.json by using https://www.npmjs.com/package/untildify

anhthang commented 4 years ago

@er1c thank you for this PR. it's great if commander or inquirer can support both. Did you try?

er1c commented 4 years ago

@buianhthang I did look into it. I can remove the prompting, but I thought it a nice feature. Inquirer has a "this isn't for command line args: see commander"

commander has required parameters, but not console prompting beyond the var args

er1c commented 4 years ago

@buianhthang FYI, I'm playing with/adding additional swagger generation options: https://github.com/er1c/soap-converter/commit/81e6800c6abbc235a0a0012de157d3b3523e7751#diff-04c6e90faac2675aa89e2176d2eec7d8R30 do you want me to submit a PR when I get those ready? (I'm purposefully trying to keep the PRs small/easy to review)

anhthang commented 4 years ago

@er1c I also think it’s nice feature. I just want to make sure that we don’t use multiple packages with the same features

New PRs are welcome. Thank you :D