search

anhttran / extreme_3d_faces

Extreme 3D Face Reconstruction: Looking Past Occlusions
Other
785 stars 184 forks source link

minor bug maybe #9

Closed fwbx529 closed 6 years ago

fwbx529 commented 6 years ago

In modules/PoseExpr/src/FaceServices2.cpp, line 390 I think it should be as followed (init with 0)

cv::Mat out(2*M+EM+RENDER_PARAMS_COUNT,1,CV_32F,cv::Scalar(0));

as when I check the different output of the same data, this function computeGradient sometimes gives me a mat containing some NANs

image

anhttran commented 6 years ago

Depend on the optimizing stage, I do not set and use some parameters. Hence, it is fine if their values are NANs. Regardless, many thanks for your suggestion.