ani-hovhannisyan / kanji-visualization

Kanji words visualization graph draws relational graph for kanjis of particular words in Japanese. Aim is to understand the relational graph of one kanji within different words and it's relations to all possible words.

MIT License

5 stars 1 forks source link

Connect SearchField and GraphView #63

Closed wowry closed 2 years ago

wowry commented 2 years ago

Reference Issues/PRs

54, #62

Changes

Change isMain key type to string in JSON format
Update type handling related to JSON format in frontend (especially in SearchField)
- Add ./frontend/src/types/global.d.ts
- Add ./frontend/src/components dir and move component files into it
Update GraphView props and connect it to SearchField
Update SearchField and GraphView to support node click events (changing the main node)

wowry commented 2 years ago

Sorry, I forgot to update handleNodeClick().

ani-hovhannisyan commented 2 years ago

That's the second case so no worries. If search flow works fine it should be easy to handle.

wowry commented 2 years ago

OK, changing the main node by clicking nodes is now supported. And GraphView receives and draws the response from the backend instead of the sample JSON file.

teruto725 commented 2 years ago

@wowry I got a error on your branch do you know something about that?

wowry commented 2 years ago

@teruto725 This error occurs because the backend has not been updated.

teruto725 commented 2 years ago

Ok, I'll check it

wowry commented 2 years ago

@teruto725 I'd like to bundle the current PRs into develop branch and make sure that this error disappears there.

wowry commented 2 years ago

@teruto725 Do you have any other comments? If there are none, I'd like to merge this PR into develop before merging into main.

wowry commented 2 years ago

Speaking of which, I removed the search button to simplify the second flow when switching the main node.