ani-hovhannisyan / kanji-visualization

Kanji words visualization graph draws relational graph for kanjis of particular words in Japanese. Aim is to understand the relational graph of one kanji within different words and it's relations to all possible words.
MIT License
5 stars 1 forks source link

Links aren't drawn when searching some specific kanji #80

Closed ani-hovhannisyan closed 2 years ago

ani-hovhannisyan commented 2 years ago

Some kanji (耶) search have no links. Probably, it comes from graph controller, have to debug, pics below: Screenshot from 2022-02-21 10-22-12

ani-hovhannisyan commented 2 years ago

I did debugging of Graph Controller, and it was right. The bug occurs when there's no word where the searched kanji itself has word meaning, like 山 itself is a word which means ”mountain”, but 耶 has no meaning if only it is written alone without any other kanji. Therefore, after GC logic works it can't find one 耶 kanji as word, so never puts it into nodes list, therefore main node is skipped from words json list. Now, working on this to add another if case for such words too.

ani-hovhannisyan commented 2 years ago

This fix is not covering case when one word has same searched kanji 2 times, should be discussed this case later. Kanji like 高い高い of course it has okurigana so I will not draw it. Should be discussed..

ani-hovhannisyan commented 2 years ago

I also saw something like no main kanji but word has it's old writing, should be discussed too. Example: when some different kanji have no arrow to main 高 kanji. Like the kanji has a word 激昂, but there's no it's kanji inside that word. As it's old word of 激高, what should be passed to the json, because now graph is like the picture. Screenshot from 2022-02-21 11-36-58