ani-memes / AMII

A plugin that adds Anime Memes to your JetBrains IDEs
https://plugins.jetbrains.com/plugin/15865-amii
Apache License 2.0
271 stars 15 forks source link

Have always sound on test completion. #156

Closed Legion112 closed 3 months ago

Legion112 commented 2 years ago

I would like to force always have sound notification on test failer. This would help me to return back to work after long time of procastination during waiting for test result.

Dragon-0609 commented 2 years ago

Not all memes have sound. So, I think @Unthrottled could add an option to show just memes with sound for build results like successful built, build failed and etc.

Legion112 commented 2 years ago

That would be greate.

Legion112 commented 2 years ago

Where I can see list of meme wich has sound? Maybe I could limit only those which has it?

Dragon-0609 commented 2 years ago

Here you can see all memes: https://amii-assets.unthrottled.io/

Dragon-0609 commented 2 years ago

I think at the moment there's no filter for memes with and without sounds in that website. So, you can just press in every meme and see if it has the sound.

Unthrottled commented 2 years ago

Ah yeah, the older version of the plugin used to randomly associate a sound to a visual asset (I think, don't remember). So I feel it's fair to resurrect it.

Anyways, with custom assets, I think I can add the ability for users to provide a pool of sound assets. They can be tagged with: Positive, Negative, Neutral (or some other mapping) that allows me to associate a visual asset with an audible asset.

Then I can add a setting for each event type (startup, test, exit code, etc) as to whether play a random sound, from the random audible asset pool, on event dispatch.

I might work on this sooner if I feel like procrastinating on what I am currently working on.

Legion112 commented 2 years ago

Could you provide a list of command what need to be run in order to build project? So contribution would be mush simpler. @Unthrottled

Unthrottled commented 2 years ago

The plugin uses the intellij gradle plugin. So you can follow the plugin guide provided by JetBrains.

I'd appreciate contributions, however this is a fairly involved feature. So I'd like something that I can easily maintain. I've got some requirements I'll list if you are wanting implement this.

Legion112 commented 2 years ago

@Unthrottled sure you could list it.

Unthrottled commented 2 years ago

To keep the initial feature simple, I'm would prefer if the scope remain just to the test events.

This list isn't exhaustive, but I think it is a good start.

Some extra references:

https://github.com/ani-memes/AMII/issues/151#issuecomment-1188431985 https://github.com/ani-memes/AMII/pull/153

If that's too much work, you can always just Only use custom assets and always provide sound for your custom assets :)