search

ani1609 / Spendwise

Spendwise - Your User-Friendly Expense Tracker
https://spendwise-seven.vercel.app/
MIT License
26 stars 49 forks source link

BUG: Form is closing when clicking outside of the form. #231

Closed chandiran-v closed 9 months ago

chandiran-v commented 9 months ago

Describe the bug The form to sign up/login is closed when we click on the screen except the form.

To Reproduce Steps to reproduce the behavior:

  1. Go to Spendwise
  2. Click on Login/Signup button
  3. Click outside of the form
  4. See the behavior

Expected behavior The form should not be closed when we click outside of the form. By placing cross icon at the top right corner and adding function to close to the icon should solve the issue.

Screenshots

Uploading Bug.mp4…

C0DE-SLAYER commented 9 months ago

can you assign me this issue i would like to work on it under KWOC23

ani1609 commented 9 months ago

@chandiran-v actually i have developed the form in such way that clicking outside of it will close the form because the form has no dedicated closing button. Do let me know if you have any better option (like integrating a new cross button fro closing the form)

ani1609 commented 9 months ago

@C0DE-SLAYER before working on the issue, please share the alternative you have thought about. We simply cannot restrict the user from closing the form.

chandiran-v commented 9 months ago

@chandiran-v actually i have developed the form in such way that clicking outside of it will close the form because the form has no dedicated closing button. Do let me know if you have any better option (like integrating a new cross button fro closing the form)

Yes, integrating cross button will be more user friendly. Also I haven't seen any such design to close automatically when we click outside of the form. If I entering my credentials and in half way, accidentally pressed outside of the form, the form closes automatically without any warning/indication and also I have to redo the same process. If we give users a close button, it is much more convenient to use since the background also blurred. Also it is mandatory to signup/login, so as a user I must login/signup to use the app. Abruptly closing the form when clicking outside makes no sense in my opinion. What is your view @ani1609? Close the issue if I am wrong.

ani1609 commented 9 months ago

@chandiran-v okay, lets add a cross button. Do you wanna work on this issue?

chandiran-v commented 9 months ago

Yes. I am interested.

ani1609 commented 9 months ago

@chandiran-v okay