ani1609 / Spendwise

Spendwise - Your User-Friendly Expense Tracker
https://spendwise-seven.vercel.app/
MIT License
26 stars 50 forks source link

Add Password Visibility Toggle Feature #246

Closed ani1609 closed 6 months ago

ani1609 commented 6 months ago

Objective: Implement a password visibility toggle feature in the user authentication form to allow users to easily view and hide their entered password.

Details: The current user authentication form includes a password input field for users to enter their passwords securely. However, there is no option for users to view their entered password. This feature is commonly seen in modern authentication forms for user convenience.

Proposed Solution:

Add an eye icon next to the password input field. Allow users to toggle between password visibility and hidden state by clicking the eye icon. Ensure the toggle functionality does not compromise security.

duongruong commented 6 months ago

Can I do it?

ani1609 commented 6 months ago

@duongruong sure

ayann07 commented 6 months ago

can I work for this under KWOC.

mendacium-a11y commented 6 months ago

hey, i have actually fixed this already, almost ready to push a pull request, if it isn't a problem @ani1609 @ayann07 ?

https://github.com/ani1609/Spendwise/assets/110321699/c9f985e2-fcbd-431b-b2d0-14cf1c5f1bd8

this is how I have implemented this

ani1609 commented 6 months ago

@mendacium-a11y please make the Ui like this

Screenshot 2023-12-23 at 2 09 38 AM

(refer to the eye icon only and not the label)

mendacium-a11y commented 6 months ago

just for the icon or for the placement as well

mendacium-a11y commented 6 months ago

https://github.com/ani1609/Spendwise/assets/110321699/56204cb4-58c7-41b2-ba95-50ee6cf41b05

here's how it's looking now

ani1609 commented 6 months ago

@mendacium-a11y good, please make the icon a little bit smaller and create a PR

mendacium-a11y commented 6 months ago

on it

mendacium-a11y commented 6 months ago

hey, @ani1609 , could you take a look at the pr whenver possible

mendacium-a11y commented 6 months ago

@ani1609 i have created another pr, i was having some trouble with my last branch, so couldn't commit to the same pr, you can have a look now, the animation also works like it should

ani1609 commented 6 months ago

@mendacium-a11y done