ani1609 / Spendwise

Spendwise - Your User-Friendly Expense Tracker
https://spendwise-seven.vercel.app/
MIT License
25 stars 49 forks source link

Made a toggle to show password on login page #256

Closed mendacium-a11y closed 9 months ago

mendacium-a11y commented 9 months ago

Pull Request

Related Issues:

246

Fixes #(issue number)

Description: added a button in the password input field to toggle hiding password or not

Checklist:

Screenshots: Screenshot from 2023-12-23 17-55-15 Screenshot from 2023-12-23 17-55-20

vercel[bot] commented 9 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @ani1609 on Vercel.

@ani1609 first needs to authorize it.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spendwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 7:40am
spendwise-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 7:40am
ani1609 commented 9 months ago

@mendacium-a11y you have messed up the animation. please fix it and keep it as like before.

mendacium-a11y commented 9 months ago

ok let me check

mendacium-a11y commented 9 months ago

so the problem seems to be that vanilla css and tailwind are being used together and hence, not being able to achieve the desired result

am trying to figure out how to make it work, might have to convert all to tailwind

ani1609 commented 9 months ago

@mendacium-a11y the css properties may be over ridding each others. Use insect from browser.

mendacium-a11y commented 9 months ago

I am really sorry for going awol on this issue, had some things come up, just hadn't had the chance to jump back on it

ani1609 commented 9 months ago

@mendacium-a11y okay no worries, please complete the issue.

mendacium-a11y commented 9 months ago

yeah definitely, thanks for understanding