ani1609 / Spendwise

Spendwise - Your User-Friendly Expense Tracker
https://spendwise-seven.vercel.app/
MIT License
27 stars 50 forks source link

Change transaction form input border colours #294

Closed ani1609 closed 6 months ago

ani1609 commented 6 months ago
Screenshot 2023-12-29 at 2 17 03 PM

Change the border colours of 'Amount'. 'Category', 'Description', and 'Date' forms to '#B6CEFC80' when in dark mode

ShahnawazHussain28 commented 6 months ago

Please assign this issue to me. Let me fix this really quick

ani1609 commented 6 months ago

@ShahnawazHussain28 sure

ShahnawazHussain28 commented 6 months ago

It is resolved. Please merge the PR #306

ani1609 commented 6 months ago

@ShahnawazHussain28 you have removed some of the css properties in you latest commit where you tried to resolve the merge conflicts

Current production views are-

Screenshot 2023-12-30 at 1 01 46 AM Screenshot 2023-12-30 at 1 01 55 AM

But the preview of your PR looks like-

Screenshot 2023-12-30 at 1 01 02 AM Screenshot 2023-12-30 at 1 01 12 AM

Try to commit your changes after taking a pull from the main branch

ani1609 commented 6 months ago

@ShahnawazHussain28 one more thing, !important property is used for setting border colours in. plain ExpenseTracker.css file, please remove them and use only tailwind css. Also keep a transition duration of 500ms while changing the border colours. (come over the slack channel if you face any problems)

ShahnawazHussain28 commented 6 months ago

Thank you for the providing the comparative analysis. But we are using tailwind dark mode config. If a property is marked as important in the css file. Tailwind cannot override it using the dark: prefix. Have to modify the css file either way. And also the border color was applied to a css class ".cursor-pointer" which is a tailwind class. It should be strictly avoided.

ani1609 commented 6 months ago

@ShahnawazHussain28 i too realised that and that is why i asked you to delete those plain css properties

ShahnawazHussain28 commented 6 months ago

It is using same css properties at many places. Almost all element contain the same border color style. It should not be set through tailwind because if you want to change a color you have to do it everywhere. That's why I've created a css variable for the dark mode border color and assigned them through css. Now you just have to change the variable value if you want and boom, everything will update. Check my PR #307