ani1609 / Spendwise

Spendwise - Your User-Friendly Expense Tracker
https://spendwise-seven.vercel.app/
MIT License
27 stars 50 forks source link

border colors of transactions for dark mode has been change to #B6CEF… #308

Closed Sabbirfeni closed 6 months ago

Sabbirfeni commented 6 months ago

…C80. issue solved

Pull Request

Related Issues: https://github.com/ani1609/Spendwise/issues/295

Fixes #(issue number)

295

Description: Step 1 - ExpenseTracker.css file: commented out 106 line.

Step 2 - Transactions.js file: Added "border-[#6e9df7] dark:border-[#B6CEFC80]" to className of li html tag at ine 209 and 225

Checklist:

Screenshots: dark mode border

vercel[bot] commented 6 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @ani1609 on Vercel.

@ani1609 first needs to authorize it.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spendwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 9:15am
spendwise-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 9:15am
ani1609 commented 6 months ago

@Sabbirfeni thats on me, dont worry

Sabbirfeni commented 6 months ago

Okay great

Sabbirfeni commented 6 months ago

This input field's border color might need to be changed on dark mode.

input field

ani1609 commented 6 months ago

@Sabbirfeni appreciated

Sabbirfeni commented 6 months ago

@Sabbirfeni appreciated

Glad to contribute on this project.

Sabbirfeni commented 6 months ago

This input field's border color might need to be changed on dark mode.

input field

@ani1609 what you think about this?

ani1609 commented 6 months ago

@Sabbirfeni actually we need to have a uniform colour coordination, all the borders should look coloured uniformly

Sabbirfeni commented 6 months ago

What does it mean by uniform please?

ani1609 commented 6 months ago

@Sabbirfeni i basically mean to maintain same colour standards for elements

Sabbirfeni commented 6 months ago

I got it.

If you like to do so, you can assign me to the issue.

ani1609 commented 6 months ago

@Sabbirfeni The issue has already been assigned to someone. Look for other issues to work on or feel free to raise new issues as well.

Sabbirfeni commented 6 months ago

Great

Sabbirfeni commented 6 months ago

Can we join on Linkedin?

ani1609 commented 6 months ago

@Sabbirfeni sure

Sabbirfeni commented 6 months ago

This is my linkedin. Please send connect request over. https://www.linkedin.com/in/amdadul-hoq-shabbir-185b7424a/

Sabbirfeni commented 6 months ago

Your portfolio site is amaizing. Did you build it by yourself or use tamplate?

ani1609 commented 6 months ago

@Sabbirfeni My portfolio website is wholly developed by me.